Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194833002: Overscroll and Elasticity for views::ScrollView

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, tdresser+watch_chromium.org, Ian Vollick, tfarina, dtapuska+chromiumwatch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20160728-MacViews-RouteThroughInputHandler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Overscroll and Elasticity for views::ScrollView Overview CL: http://crrev.com/2189583004 BUG=615948 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 #

Patch Set 2 : rebase, pull in deferred stuff #

Patch Set 3 : fix dep #

Patch Set 4 : Rebase+fix compile but something broke #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase at r421086 #

Patch Set 8 : rebase omigosh but it is a bit broken still #

Patch Set 9 : Restore functionality and fix bugs \o/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+726 lines, -239 lines) Patch
M cc/blimp/layer_tree_host_remote.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_layer_impl.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M cc/input/input_handler.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download
M cc/input/scroll_elasticity_helper.h View 3 chunks +8 lines, -0 lines 0 comments Download
M cc/input/scroll_elasticity_helper.cc View 1 2 3 4 5 6 3 chunks +105 lines, -2 lines 0 comments Download
M cc/input/scroll_state.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/layer.h View 1 2 3 4 5 6 7 4 chunks +12 lines, -2 lines 0 comments Download
M cc/layers/layer.cc View 1 2 3 4 5 6 7 9 chunks +35 lines, -12 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 4 5 6 7 3 chunks +10 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 5 6 7 5 chunks +24 lines, -8 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -0 lines 0 comments Download
M cc/proto/begin_main_frame_and_commit_state.proto View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/proto/layer.proto View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M cc/proto/property_tree.proto View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_json_parser.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M cc/test/test_layer_tree_host_base.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/draw_property_utils.cc View 1 2 3 4 5 6 7 1 chunk +8 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 7 4 chunks +12 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 8 4 chunks +48 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 4 5 6 7 7 chunks +31 lines, -4 lines 0 comments Download
M cc/trees/property_tree.h View 1 2 3 4 5 6 7 4 chunks +41 lines, -10 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 3 4 5 6 7 11 chunks +109 lines, -63 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -3 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/transform_node.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/transform_node.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -4 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 2 3 4 5 6 7 3 chunks +29 lines, -25 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/layer.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M ui/compositor/overscroll/ui_input_handler.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
M ui/compositor/overscroll/ui_input_handler.cc View 1 2 3 4 5 6 7 8 2 chunks +25 lines, -3 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -3 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -2 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller.h View 1 2 3 4 5 6 2 chunks +11 lines, -2 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller.cc View 4 chunks +74 lines, -46 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller_unittest.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M ui/views/examples/scroll_view_example.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/views/examples/scroll_view_example.cc View 4 chunks +49 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
tapted
Description was changed from ========== Overscroll and Elasticity for views::ScrollView BUG=615948 ========== to ========== Overscroll ...
4 years, 4 months ago (2016-07-29 08:06:33 UTC) #1
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-08 07:44:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194833002/80001
4 years, 4 months ago (2016-08-08 07:44:55 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 07:55:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/179467) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 4 months ago (2016-08-08 07:55:34 UTC) #5
tapted
4 years, 4 months ago (2016-08-15 08:50:48 UTC) #6 
Description was changed from

==========
Overscroll and Elasticity for views::ScrollView

BUG=615948
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Overscroll and Elasticity for views::ScrollView

Overview CL: http://crrev.com/2189583004

BUG=615948
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

Powered by Google App Engine
This is Rietveld 408576698