Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2194823004: MD Settings: Fix footer text alignment in CBD. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix footer text alignment in CBD. Credit goes to @dbeam. BUG=632674 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f3f190e3b53ed08c5db21f8c042735b3862a1281 Cr-Commit-Position: refs/heads/master@{#408749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dpapad
Screenshots at http://imgur.com/a/HkreY.
4 years, 4 months ago (2016-07-29 18:28:10 UTC) #3
Dan Beam
lgtm
4 years, 4 months ago (2016-07-29 18:29:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194823004/1
4 years, 4 months ago (2016-07-29 18:33:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 21:12:21 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:15:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3f190e3b53ed08c5db21f8c042735b3862a1281
Cr-Commit-Position: refs/heads/master@{#408749}

Powered by Google App Engine
This is Rietveld 408576698