Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2194823003: Use HashSet instead of Dynamic hash for tracking vulkan resources (Closed)

Created:
4 years, 4 months ago by egdaniel
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@mergeProgDesc
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use HashSet instead of Dynamic hash for tracking vulkan resources BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194823003 Committed: https://skia.googlesource.com/skia/+/00db3fd7a790ecfbb4ce3c65572e1bee2a0078db

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : nits #

Total comments: 2

Patch Set 4 : review cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/gpu/vk/GrVkResource.h View 1 2 3 2 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
egdaniel
4 years, 4 months ago (2016-07-29 13:59:57 UTC) #3
mtklein
lgtm https://codereview.chromium.org/2194823003/diff/40001/src/gpu/vk/GrVkResource.h File src/gpu/vk/GrVkResource.h (right): https://codereview.chromium.org/2194823003/diff/40001/src/gpu/vk/GrVkResource.h#newcode51 src/gpu/vk/GrVkResource.h:51: if (fHashSet.count()) { No real need for this ...
4 years, 4 months ago (2016-07-29 14:33:20 UTC) #4
egdaniel
https://codereview.chromium.org/2194823003/diff/40001/src/gpu/vk/GrVkResource.h File src/gpu/vk/GrVkResource.h (right): https://codereview.chromium.org/2194823003/diff/40001/src/gpu/vk/GrVkResource.h#newcode51 src/gpu/vk/GrVkResource.h:51: if (fHashSet.count()) { On 2016/07/29 14:33:19, mtklein wrote: > ...
4 years, 4 months ago (2016-07-29 15:05:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194823003/60001
4 years, 4 months ago (2016-07-29 15:05:56 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 15:55:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/00db3fd7a790ecfbb4ce3c65572e1bee2a0078db

Powered by Google App Engine
This is Rietveld 408576698