Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2194823002: [gn] Switch msan bots to gn (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch msan bots to gn BUG=chromium:631979 NOTRY=true Committed: https://crrev.com/45d0c051e2c829194a0e0a2a8e87eb50232db31a Cr-Commit-Position: refs/heads/master@{#38207}

Patch Set 1 #

Patch Set 2 : [gn] Switch msan bots to gn #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M infra/mb/mb_config.pyl View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL. This works now after a bunch of upstream and gyp changes. Comparison: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/9962/steps/compare%20build%20flags%20%28fyi%29/logs/stdio
4 years, 4 months ago (2016-08-01 11:16:22 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-01 12:15:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194823002/60001
4 years, 4 months ago (2016-08-01 12:31:28 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-01 12:33:09 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 12:35:57 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/45d0c051e2c829194a0e0a2a8e87eb50232db31a
Cr-Commit-Position: refs/heads/master@{#38207}

Powered by Google App Engine
This is Rietveld 408576698