Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2194813002: Delete unused field within .build_config: resources_deps (Closed)

Created:
4 years, 4 months ago by agrieve
Modified:
4 years, 4 months ago
Reviewers:
smaier
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused field within .build_config: resources_deps BUG=none Committed: https://crrev.com/46d235fc7011396de5d44266b741aa7961a063f9 Cr-Commit-Position: refs/heads/master@{#408645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/android/gyp/write_build_config.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
agrieve
On 2016/07/29 15:48:35, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:smaier@chromium.org
4 years, 4 months ago (2016-07-29 15:48:41 UTC) #7
smaier
lgtm
4 years, 4 months ago (2016-07-29 15:50:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194813002/1
4 years, 4 months ago (2016-07-29 15:52:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 15:55:53 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 15:58:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46d235fc7011396de5d44266b741aa7961a063f9
Cr-Commit-Position: refs/heads/master@{#408645}

Powered by Google App Engine
This is Rietveld 408576698