chrome_frame/urlmon_bind_status_callback.cc - Issue 21948002: Add missing DCHECK to validate HR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/urlmon_bind_status_callback.cc

Issue 21948002: Add missing DCHECK to validate HR. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix error testing Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/urlmon_bind_status_callback.cc

diff --git a/chrome_frame/urlmon_bind_status_callback.cc b/chrome_frame/urlmon_bind_status_callback.cc

index 006e20e923123dc860add889ae9aabaafb974256..056ea5ec21057f919bc6c5dc7455028bc4bd8989 100644

--- a/chrome_frame/urlmon_bind_status_callback.cc

+++ b/chrome_frame/urlmon_bind_status_callback.cc

@@ -320,6 +320,8 @@ STDMETHODIMP BSCBStorageBind::OnStopBinding(HRESULT hresult, LPCWSTR error) {

ExceptionBarrier barrier;

HRESULT hr = MayPlayBack(BSCF_LASTDATANOTIFICATION);

+ if (FAILED(hr))

+ return hr;

hr = CallbackImpl::OnStopBinding(hresult, error);

ReleaseBind();

return hr;

« no previous file with comments | « no previous file | chrome_frame/urlmon_moniker.cc » ('j') | no next file with comments »