Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194793006: Do not commit: Revert of r404081 and r402757 for perf testing purposes. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not commit: Revert of r404081 and r402757 for perf testing purposes. This CL was made by running: git revert 5c480f3117fe314b8cace4f33b84020e9e3424e2 git revert 18d455ee833f6a30dcbe2755380861eb75cd9f6f This reverts "Fix layout object lifecycle in HTMLElement.offset*" and then "Implement closed shadow adjustment for Element.offsetParent". This is not intended to be committed. BUG=625462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -419 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/crashes/offsetParent-layoutObject-lifecycle.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/offsetParent.html View 1 chunk +0 lines, -244 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 5 chunks +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 2 chunks +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 3 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVideo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVideo.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
qyearsley
4 years, 4 months ago (2016-07-29 15:48:03 UTC) #1 
Description was changed from

==========
Revert of r404081 and r402757 for perf testing purposes.

This CL was made by running:

    git revert 5c480f3117fe314b8cace4f33b84020e9e3424e2
    git revert 18d455ee833f6a30dcbe2755380861eb75cd9f6f

This reverts "Fix layout object lifecycle in HTMLElement.offset*"
and then "Implement closed shadow adjustment for Element.offsetParent".

BUG=625462
==========

to

==========
Do not commit: Revert of r404081 and r402757 for perf testing purposes.

This CL was made by running:

    git revert 5c480f3117fe314b8cace4f33b84020e9e3424e2
    git revert 18d455ee833f6a30dcbe2755380861eb75cd9f6f

This reverts "Fix layout object lifecycle in HTMLElement.offset*"
and then "Implement closed shadow adjustment for Element.offsetParent".

This is not intended to be committed.

BUG=625462
==========

Powered by Google App Engine
This is Rietveld 408576698