Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: src/heap/heap.h

Issue 2194793005: [heap] No leakage of store-buffer.h outside of heap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index f7a2ae2fbc0109888a07974b62e0830ab6d38be7..39c15afdfd18e6d875231a6dc104d0b4838f3d9a 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -16,9 +16,8 @@
#include "src/base/atomic-utils.h"
#include "src/globals.h"
#include "src/heap-symbols.h"
-// TODO(mstarzinger): Two more includes to kill!
+// TODO(mstarzinger): One more include to kill!
#include "src/heap/spaces.h"
-#include "src/heap/store-buffer.h"
#include "src/list.h"
namespace v8 {
@@ -326,6 +325,7 @@ class MemoryReducer;
class ObjectStats;
class Scavenger;
class ScavengeJob;
+class StoreBuffer;
class WeakObjectRetainer;
enum PromotionMode { PROMOTE_MARKED, DEFAULT_PROMOTION };
@@ -1128,7 +1128,7 @@ class Heap {
inline void RecordFixedArrayElements(FixedArray* array, int offset,
int length);
- Address* store_buffer_top_address() { return store_buffer()->top_address(); }
+ inline Address* store_buffer_top_address();
void ClearRecordedSlot(HeapObject* object, Object** slot);
void ClearRecordedSlotRange(Address start, Address end);
@@ -1551,7 +1551,7 @@ class Heap {
ROOT_LIST(ROOT_ACCESSOR)
#undef ROOT_ACCESSOR
- StoreBuffer* store_buffer() { return &store_buffer_; }
+ StoreBuffer* store_buffer() { return store_buffer_; }
void set_current_gc_flags(int flags) {
current_gc_flags_ = flags;
@@ -2193,7 +2193,7 @@ class Heap {
MemoryAllocator* memory_allocator_;
- StoreBuffer store_buffer_;
+ StoreBuffer* store_buffer_;
IncrementalMarking* incremental_marking_;
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698