Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2194793005: [heap] No leakage of store-buffer.h outside of heap. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] No leakage of store-buffer.h outside of heap. This prevents the internal store-buffer.h header to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=hpayer@chromium.org Committed: https://crrev.com/de79665c726daf7e2525f9fc1bc2798abf7cea00 Cr-Commit-Position: refs/heads/master@{#38201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/heap/heap.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +7 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-07-29 12:11:12 UTC) #3
Hannes Payer (out of office)
YES, LGTM!
4 years, 4 months ago (2016-08-01 08:33:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194793005/1
4 years, 4 months ago (2016-08-01 10:39:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 11:10:05 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:12:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de79665c726daf7e2525f9fc1bc2798abf7cea00
Cr-Commit-Position: refs/heads/master@{#38201}

Powered by Google App Engine
This is Rietveld 408576698