Introduce Maybe::To/ToChecked

Introduce Maybe::To/ToChecked

Per discussion in https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vGLGCaMqhCU/discussion

BUG=

Committed: https://crrev.com/cf1779495d454003b806d50de80a2c713a782466
Cr-Commit-Position: refs/heads/master@{#38173}

[haraken, 2016-07-29 10:14:15]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 10:14:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-07-29 10:14:54]

haraken@chromium.org changed reviewers:
+ jochen@chromium.org

[haraken, 2016-07-29 10:14:55]

PTAL

[jochen (gone - plz use gerrit), 2016-07-29 10:19:08]

lgtm

[commit-bot: I haz the power, 2016-07-29 10:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 10:38:16]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-07-29 10:52:49]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-29 10:52:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 10:54:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-29 10:57:04]

Description was changed from

==========
Introduce Maybe::To/ToChecked

Per discussion in
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vG...

BUG=
==========

to

==========
Introduce Maybe::To/ToChecked

Per discussion in
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/vG...

BUG=

Committed: https://crrev.com/cf1779495d454003b806d50de80a2c713a782466
Cr-Commit-Position: refs/heads/master@{#38173}
==========

[commit-bot: I haz the power, 2016-07-29 10:57:06]

Patchset 1 (id:??) landed as
https://crrev.com/cf1779495d454003b806d50de80a2c713a782466
Cr-Commit-Position: refs/heads/master@{#38173}

[jbroman, 2016-08-02 15:02:50]

Out of curiosity, why does Maybe<T>::To take a reference, while
MaybeHandle<T>::ToLocal takes a pointer? This was surprising to me, and it also
seems to me to be out of line with the Google C++ style guide (which discourages
non-const reference parameters).

[jbroman, 2016-08-02 15:03:33]

On 2016/08/02 at 15:02:50, jbroman wrote:
> Out of curiosity, why does Maybe<T>::To take a reference, while
MaybeHandle<T>::ToLocal takes a pointer? This was surprising to me, and it also
seems to me to be out of line with the Google C++ style guide (which discourages
non-const reference parameters).

(and by MaybeHandle I mean MaybeLocal, though v8::internal::MaybeHandle is
similar)

[haraken, 2016-08-02 15:17:35]

On 2016/08/02 15:03:33, jbroman wrote:
> On 2016/08/02 at 15:02:50, jbroman wrote:
> > Out of curiosity, why does Maybe<T>::To take a reference, while
> MaybeHandle<T>::ToLocal takes a pointer? This was surprising to me, and it
also
> seems to me to be out of line with the Google C++ style guide (which
discourages
> non-const reference parameters).
> 
> (and by MaybeHandle I mean MaybeLocal, though v8::internal::MaybeHandle is
> similar)

Good point... Let me fix it tomorrow.