Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194753002: [DevTools] Add "Disable JavaScript" into command menu (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add "Disable JavaScript" into command menu BUG=619889 R=lushnikov@chromium.org Committed: https://crrev.com/4069e89321d82c86500fc78dc0b1848e4783be44 Cr-Commit-Position: refs/heads/master@{#408575}

Patch Set 1 #

Total comments: 2

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kozy
please take a look!
4 years, 4 months ago (2016-07-29 00:37:29 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/2194753002/diff/1/third_party/WebKit/Source/devtools/front_end/main/module.json File third_party/WebKit/Source/devtools/front_end/main/module.json (right): https://codereview.chromium.org/2194753002/diff/1/third_party/WebKit/Source/devtools/front_end/main/module.json#newcode225 third_party/WebKit/Source/devtools/front_end/main/module.json:225: "category": "Sources", debugger!
4 years, 4 months ago (2016-07-29 00:50:58 UTC) #2
kozy
All done! Thanks! https://codereview.chromium.org/2194753002/diff/1/third_party/WebKit/Source/devtools/front_end/main/module.json File third_party/WebKit/Source/devtools/front_end/main/module.json (right): https://codereview.chromium.org/2194753002/diff/1/third_party/WebKit/Source/devtools/front_end/main/module.json#newcode225 third_party/WebKit/Source/devtools/front_end/main/module.json:225: "category": "Sources", On 2016/07/29 00:50:58, lushnikov ...
4 years, 4 months ago (2016-07-29 01:01:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194753002/20001
4 years, 4 months ago (2016-07-29 01:02:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 04:18:03 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 04:21:35 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4069e89321d82c86500fc78dc0b1848e4783be44
Cr-Commit-Position: refs/heads/master@{#408575}

Powered by Google App Engine
This is Rietveld 408576698