Issue 219473002: Fix PrepareKeyedOperand on arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219473002: Fix PrepareKeyedOperand on arm. (Closed)

Created:
6 years, 8 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix PrepareKeyedOperand on arm. When additional_offset is specified, the 'key' operand can be negative and still pass the bounds check. Therefore, when converting key from Smi, arithmetic and not logical shift must be used. R=verwaest@chromium.org BUG=358057 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=20363

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-358057.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

6 years, 8 months ago (2014-03-31 15:14:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20363 (presubmit successful).

Expand Messages | Collapse Messages