Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

Issue 2194683003: [DevTools] Cleanup v8_inspector console API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
index 743053e0d479dc0b8cae694046d7a3121bdb406a..a1d8203a30c6508a4969587ab67dbe4d3aef0f2b 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
@@ -52,7 +52,6 @@ WorkerInspectorController::WorkerInspectorController(WorkerThread* thread, Worke
: m_debugger(debugger)
, m_thread(thread)
, m_instrumentingAgents(new InstrumentingAgents())
- , m_logAgent(nullptr)
{
}
@@ -68,8 +67,7 @@ void WorkerInspectorController::connectFrontend()
// sessionId will be overwritten by WebDevToolsAgent::sendProtocolNotification call.
m_session = new InspectorSession(this, nullptr, m_instrumentingAgents.get(), 0, true /* autoFlush */, m_debugger->debugger(), m_debugger->contextGroupId(), nullptr);
- m_logAgent = new InspectorLogAgent(m_thread->consoleMessageStorage());
- m_session->append(m_logAgent.get());
+ m_session->append(new InspectorLogAgent(m_thread->consoleMessageStorage()));
}
void WorkerInspectorController::disconnectFrontend()
@@ -107,17 +105,10 @@ void WorkerInspectorController::sendProtocolMessage(int sessionId, int callId, c
m_thread->workerReportingProxy().postMessageToPageInspector(response);
}
-void WorkerInspectorController::consoleCleared()
-{
- if (m_logAgent)
- m_logAgent->clear(nullptr);
-}
-
DEFINE_TRACE(WorkerInspectorController)
{
visitor->trace(m_instrumentingAgents);
visitor->trace(m_session);
- visitor->trace(m_logAgent);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698