Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2194673002: chrome/browser/media: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, media-router+watch_chromium.org, miu+watch_chromium.org, mcasas+watch+vc_chromium.org, feature-media-reviews_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/media: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=sergeyu@chromium.org BUG=554600 Committed: https://crrev.com/fabf492cd95ecc8450cef4f46da08652d694c206 Cr-Commit-Position: refs/heads/master@{#408715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/media/tab_desktop_media_list.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-28 23:43:43 UTC) #1
Sergey Ulanov
lgtm
4 years, 4 months ago (2016-07-29 00:01:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194673002/1
4 years, 4 months ago (2016-07-29 18:38:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:20:41 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:22:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fabf492cd95ecc8450cef4f46da08652d694c206
Cr-Commit-Position: refs/heads/master@{#408715}

Powered by Google App Engine
This is Rietveld 408576698