Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc

Issue 2194653002: chrome/browser/safe_browsing: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc
diff --git a/chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc b/chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc
index 62358c2328539c32214618b542e7959959ba4ec6..d0eeed69bc93b5f45da0c4efae948bbf3457be66 100644
--- a/chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc
+++ b/chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc
@@ -63,7 +63,7 @@ class MacSignatureEvaluatorTest : public testing::Test {
bool SetupXattrs(const base::FilePath& path) {
char sentinel = 'A';
- for (const auto& xattr : xattrs) {
+ for (auto* xattr : xattrs) {
std::vector<uint8_t> buf(10);
memset(&buf[0], sentinel++, buf.size());
if (setxattr(path.value().c_str(), xattr, &buf[0], buf.size(), 0, 0) != 0)
@@ -322,7 +322,7 @@ TEST_F(MacSignatureEvaluatorTest, ModifiedBundleTest) {
EXPECT_EQ(6, mainmenunib->signature().xattr_size());
// Manually convert the global xattrs array to a vector
std::vector<std::string> xattrs_known;
- for (const auto& xattr : xattrs)
+ for (auto* xattr : xattrs)
xattrs_known.push_back(xattr);
std::vector<std::string> xattrs_seen;
« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698