Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2194643003: chrome/browser/printing: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/printing: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=alekseys@chromium.org BUG=554600 Committed: https://crrev.com/19df8256c07f1c044cb3638849ea8bc928493b2e Cr-Commit-Position: refs/heads/master@{#408712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/printing/print_view_manager_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-28 23:43:07 UTC) #1
Aleksey Shlyapnikov
lgtm
4 years, 4 months ago (2016-07-29 17:26:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194643003/1
4 years, 4 months ago (2016-07-29 18:36:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:18:03 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:20:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19df8256c07f1c044cb3638849ea8bc928493b2e
Cr-Commit-Position: refs/heads/master@{#408712}

Powered by Google App Engine
This is Rietveld 408576698