Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2194613002: chrome/utility/safe_browsing: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
mattm
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/utility/safe_browsing: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=mattm@chromium.org BUG=554600 Committed: https://crrev.com/b20a6b27f2c4a845973b4d8cc828ef3c2f51f050 Cr-Commit-Position: refs/heads/master@{#408728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/utility/safe_browsing/mac/hfs.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/safe_browsing/mac/udif.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-28 23:45:04 UTC) #1
mattm
lgtm
4 years, 4 months ago (2016-07-29 01:44:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194613002/1
4 years, 4 months ago (2016-07-29 18:38:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:34:25 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:35:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b20a6b27f2c4a845973b4d8cc828ef3c2f51f050
Cr-Commit-Position: refs/heads/master@{#408728}

Powered by Google App Engine
This is Rietveld 408576698