Issue 219453005: Add eg...@google.com to CQ_COMMITTERS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219453005: Add eg...@google.com to CQ_COMMITTERS (Closed)

Created:
6 years, 8 months ago by bsalomon

Modified:
6 years, 8 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com, egdaniel

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add eg...@google.com to CQ_COMMITTERS R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=13997

Patch Set 2 : add chromium #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	CQ_COMMITTERS	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmistry

LGTM https://codereview.chromium.org/219453005/diff/1/CQ_COMMITTERS File CQ_COMMITTERS (right): https://codereview.chromium.org/219453005/diff/1/CQ_COMMITTERS#newcode8 CQ_COMMITTERS:8: egdaniel@google.com Add a chromium.org account too? (assuming there ...

6 years, 8 months ago (2014-03-31 18:25:02 UTC) #2

bsalomon

https://codereview.chromium.org/219453005/diff/1/CQ_COMMITTERS File CQ_COMMITTERS (right): https://codereview.chromium.org/219453005/diff/1/CQ_COMMITTERS#newcode8 CQ_COMMITTERS:8: egdaniel@google.com On 2014/03/31 18:25:02, rmistry wrote: > Add a ...

6 years, 8 months ago (2014-03-31 18:38:00 UTC) #3

bsalomon

6 years, 8 months ago (2014-03-31 18:39:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13997 (presubmit successful).

Expand Messages | Collapse Messages

Issue 219453005: Add eg...@google.com to CQ_COMMITTERS (Closed)

Description

Patch Set 1 #

Patch Set 2 : add chromium #

Messages