Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 219453004: Correct the null focusedFrame() check in Document (Closed)

Created:
6 years, 8 months ago by kenrb
Modified:
6 years, 8 months ago
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Correct the null focusedFrame() check in Document Blink revision 170347 introduced a crash because Document::focusedFrame() fails to check properly for having a null Frame. This corrects the check. BUG=358172 R=eseidel@chromium.org, abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kenrb
Eric or Adam can one of you PTAL? This is a small change to fix ...
6 years, 8 months ago (2014-03-31 17:35:43 UTC) #1
eseidel
lgtm
6 years, 8 months ago (2014-03-31 17:59:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/219453004/1
6 years, 8 months ago (2014-03-31 18:00:00 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 18:10:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-03-31 18:10:40 UTC) #5
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 8 months ago (2014-03-31 18:15:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/219453004/1
6 years, 8 months ago (2014-03-31 18:15:25 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 19:18:35 UTC) #8
Message was sent while issue was closed.
Change committed as 170478

Powered by Google App Engine
This is Rietveld 408576698