runtime/vm/debugger.cc - Issue 2194493002: DBC: Fix not-stopping/crashing at fast Smi op breakpoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 2194493002: DBC: Fix not-stopping/crashing at fast Smi op breakpoints. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: year Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index a52cf4a53e88a8788d17e8b722272aa6cae06a9d..6b50583c2c8ced0fb091c69788705bccde454aa5 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -1108,7 +1108,8 @@ CodeBreakpoint::CodeBreakpoint(const Code& code,

#if !defined(TARGET_ARCH_DBC)

saved_value_(Code::null())

#else

- saved_value_(Bytecode::kTrap)

+ saved_value_(Bytecode::kTrap),

+ saved_value_fastsmi_(Bytecode::kTrap)

#endif

{

ASSERT(!code.IsNull());

« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/debugger_dbc.cc » ('j') | no next file with comments »