Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: runtime/vm/constants_dbc.h

Issue 2194493002: DBC: Fix not-stopping/crashing at fast Smi op breakpoints. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: year Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index e84ae57e8e2fa89c1bc40ed3276c50e41bfce63c..564e96394ab72bf3a7eba93bc426686555cf689e 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -754,6 +754,23 @@ BYTECODES_LIST(DECLARE_BYTECODE)
}
}
+ DART_FORCE_INLINE static bool IsFastSmiOpcode(Instr instr) {
+ switch (DecodeOpcode(instr)) {
+ case Bytecode::kAddTOS:
+ case Bytecode::kSubTOS:
+ case Bytecode::kMulTOS:
+ case Bytecode::kBitOrTOS:
+ case Bytecode::kBitAndTOS:
+ case Bytecode::kEqualTOS:
+ case Bytecode::kLessThanTOS:
+ case Bytecode::kGreaterThanTOS:
+ return true;
+
+ default:
+ return false;
+ }
+ }
+
DART_FORCE_INLINE static uint8_t DecodeArgc(Instr call) {
ASSERT(IsCallOpcode(call));
return (call >> 8) & 0xFF;
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698