Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Side by Side Diff: runtime/vm/debugger.h

Issue 2194493002: DBC: Fix not-stopping/crashing at fast Smi op breakpoints. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: year Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_DEBUGGER_H_ 5 #ifndef VM_DEBUGGER_H_
6 #define VM_DEBUGGER_H_ 6 #define VM_DEBUGGER_H_
7 7
8 #include "include/dart_tools_api.h" 8 #include "include/dart_tools_api.h"
9 9
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 CodeBreakpoint* next_; 228 CodeBreakpoint* next_;
229 229
230 RawPcDescriptors::Kind breakpoint_kind_; 230 RawPcDescriptors::Kind breakpoint_kind_;
231 #if !defined(TARGET_ARCH_DBC) 231 #if !defined(TARGET_ARCH_DBC)
232 RawCode* saved_value_; 232 RawCode* saved_value_;
233 #else 233 #else
234 // When running on the DBC interpreter we patch bytecode in place with 234 // When running on the DBC interpreter we patch bytecode in place with
235 // DebugBreak. This is an instruction that was replaced. DebugBreak 235 // DebugBreak. This is an instruction that was replaced. DebugBreak
236 // will execute it after the breakpoint. 236 // will execute it after the breakpoint.
237 Instr saved_value_; 237 Instr saved_value_;
238 Instr saved_value_fastsmi_;
238 #endif 239 #endif
239 240
240 friend class Debugger; 241 friend class Debugger;
241 DISALLOW_COPY_AND_ASSIGN(CodeBreakpoint); 242 DISALLOW_COPY_AND_ASSIGN(CodeBreakpoint);
242 }; 243 };
243 244
244 245
245 // ActivationFrame represents one dart function activation frame 246 // ActivationFrame represents one dart function activation frame
246 // on the call stack. 247 // on the call stack.
247 class ActivationFrame : public ZoneAllocated { 248 class ActivationFrame : public ZoneAllocated {
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 643
643 friend class Isolate; 644 friend class Isolate;
644 friend class BreakpointLocation; 645 friend class BreakpointLocation;
645 DISALLOW_COPY_AND_ASSIGN(Debugger); 646 DISALLOW_COPY_AND_ASSIGN(Debugger);
646 }; 647 };
647 648
648 649
649 } // namespace dart 650 } // namespace dart
650 651
651 #endif // VM_DEBUGGER_H_ 652 #endif // VM_DEBUGGER_H_
OLDNEW
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698