Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Side by Side Diff: runtime/vm/debugger.cc

Issue 2194493002: DBC: Fix not-stopping/crashing at fast Smi op breakpoints. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: year Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/debugger_dbc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 1090 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 token_pos_(token_pos), 1101 token_pos_(token_pos),
1102 pc_(pc), 1102 pc_(pc),
1103 line_number_(-1), 1103 line_number_(-1),
1104 is_enabled_(false), 1104 is_enabled_(false),
1105 bpt_location_(NULL), 1105 bpt_location_(NULL),
1106 next_(NULL), 1106 next_(NULL),
1107 breakpoint_kind_(kind), 1107 breakpoint_kind_(kind),
1108 #if !defined(TARGET_ARCH_DBC) 1108 #if !defined(TARGET_ARCH_DBC)
1109 saved_value_(Code::null()) 1109 saved_value_(Code::null())
1110 #else 1110 #else
1111 saved_value_(Bytecode::kTrap) 1111 saved_value_(Bytecode::kTrap),
1112 saved_value_fastsmi_(Bytecode::kTrap)
1112 #endif 1113 #endif
1113 { 1114 {
1114 ASSERT(!code.IsNull()); 1115 ASSERT(!code.IsNull());
1115 ASSERT(token_pos_.IsReal()); 1116 ASSERT(token_pos_.IsReal());
1116 ASSERT(pc_ != 0); 1117 ASSERT(pc_ != 0);
1117 ASSERT((breakpoint_kind_ & kSafepointKind) != 0); 1118 ASSERT((breakpoint_kind_ & kSafepointKind) != 0);
1118 } 1119 }
1119 1120
1120 1121
1121 CodeBreakpoint::~CodeBreakpoint() { 1122 CodeBreakpoint::~CodeBreakpoint() {
(...skipping 2194 matching lines...) Expand 10 before | Expand all | Expand 10 after
3316 3317
3317 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) { 3318 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
3318 ASSERT(bpt->next() == NULL); 3319 ASSERT(bpt->next() == NULL);
3319 bpt->set_next(code_breakpoints_); 3320 bpt->set_next(code_breakpoints_);
3320 code_breakpoints_ = bpt; 3321 code_breakpoints_ = bpt;
3321 } 3322 }
3322 3323
3323 #endif // !PRODUCT 3324 #endif // !PRODUCT
3324 3325
3325 } // namespace dart 3326 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/debugger_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698