Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2194453002: [Crankshaft] Move don't crankshaft check before EnsureDeoptimizationSupport. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-632289.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index 618747618cde269a032a77eeb0d8049c619b8b8a..f49776d0f1cd2645f1957740c8e0115cc284598c 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -116,7 +116,11 @@ class HOptimizedGraphBuilderWithPositions : public HOptimizedGraphBuilder {
};
HCompilationJob::Status HCompilationJob::CreateGraphImpl() {
- bool dont_crankshaft = info()->shared_info()->dont_crankshaft();
+ if (!isolate()->use_crankshaft() ||
+ info()->shared_info()->dont_crankshaft()) {
+ // Crankshaft is entirely disabled.
+ return FAILED;
+ }
// Optimization requires a version of fullcode with deoptimization support.
// Recompile the unoptimized version of the code if the current version
@@ -139,11 +143,6 @@ HCompilationJob::Status HCompilationJob::CreateGraphImpl() {
DCHECK(info()->shared_info()->has_deoptimization_support());
DCHECK(!info()->shared_info()->never_compiled());
- if (!isolate()->use_crankshaft() || dont_crankshaft) {
- // Crankshaft is entirely disabled.
- return FAILED;
- }
-
// Check the whitelist for Crankshaft.
if (!info()->shared_info()->PassesFilter(FLAG_hydrogen_filter)) {
return AbortOptimization(kHydrogenFilter);
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-632289.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698