Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 2194453002: [Crankshaft] Move don't crankshaft check before EnsureDeoptimizationSupport. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Crankshaft] Move don't crankshaft check before EnsureDeoptimizationSupport. Avoids compiling baseline code when the function isn't able to be optimized by crankshaft. BUG=chromium:632289 Committed: https://crrev.com/aacbdacb890500302657950ed8d2af50935e221d Cr-Commit-Position: refs/heads/master@{#38304}

Patch Set 1 #

Patch Set 2 : Add regression test #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M src/crankshaft/hydrogen.cc View 2 chunks +5 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-632289.js View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
rmcilroy
Jakob, PTAL. Michi FYI.
4 years, 4 months ago (2016-07-28 16:48:01 UTC) #4
Jakob Kummerow
LGTM with nit: Please always mention the project in the BUG= line, i.e. chromium:632289 in ...
4 years, 4 months ago (2016-08-01 08:12:58 UTC) #7
rmcilroy
On 2016/08/01 08:12:58, Jakob wrote: > LGTM with nit: > > Please always mention the ...
4 years, 4 months ago (2016-08-03 14:24:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194453002/40001
4 years, 4 months ago (2016-08-03 14:25:00 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 15:01:26 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 15:02:46 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aacbdacb890500302657950ed8d2af50935e221d
Cr-Commit-Position: refs/heads/master@{#38304}

Powered by Google App Engine
This is Rietveld 408576698