Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: tools/testing/dart/runtime_configuration.dart

Issue 2194413002: Fix build break. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library runtime_configuration; 5 library runtime_configuration;
6 6
7 import 'compiler_configuration.dart' show CommandArtifact; 7 import 'compiler_configuration.dart' show CommandArtifact;
8 8
9 // TODO(ahe): Remove this import, we can precompute all the values required 9 // TODO(ahe): Remove this import, we can precompute all the values required
10 // from TestSuite once the refactoring is complete. 10 // from TestSuite once the refactoring is complete.
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 /// program named Dump Render Tree, hence the name. 195 /// program named Dump Render Tree, hence the name.
196 class DrtRuntimeConfiguration extends DartVmRuntimeConfiguration { 196 class DrtRuntimeConfiguration extends DartVmRuntimeConfiguration {
197 int computeTimeoutMultiplier( 197 int computeTimeoutMultiplier(
198 {String mode, bool isChecked: false, bool isReload: false, String arch}) { 198 {String mode, bool isChecked: false, bool isReload: false, String arch}) {
199 return 4 // Allow additional time for browser testing to run. 199 return 4 // Allow additional time for browser testing to run.
200 // TODO(ahe): We might need to distinquish between DRT for running 200 // TODO(ahe): We might need to distinquish between DRT for running
201 // JavaScript and Dart code. I'm not convinced the inherited timeout 201 // JavaScript and Dart code. I'm not convinced the inherited timeout
202 // multiplier is relevant for JavaScript. 202 // multiplier is relevant for JavaScript.
203 * 203 *
204 super.computeTimeoutMultiplier( 204 super.computeTimeoutMultiplier(
205 mode: mode, isChecked: isChecked, isRelease: isReload); 205 mode: mode, isChecked: isChecked, isReload: isReload);
206 } 206 }
207 } 207 }
208 208
209 /// The standalone Dart VM binary, "dart" or "dart.exe". 209 /// The standalone Dart VM binary, "dart" or "dart.exe".
210 class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration { 210 class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
211 List<Command> computeRuntimeCommands( 211 List<Command> computeRuntimeCommands(
212 TestSuite suite, 212 TestSuite suite,
213 CommandBuilder commandBuilder, 213 CommandBuilder commandBuilder,
214 CommandArtifact artifact, 214 CommandArtifact artifact,
215 List<String> arguments, 215 List<String> arguments,
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration { 321 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration {
322 List<Command> computeRuntimeCommands( 322 List<Command> computeRuntimeCommands(
323 TestSuite suite, 323 TestSuite suite,
324 CommandBuilder commandBuilder, 324 CommandBuilder commandBuilder,
325 CommandArtifact artifact, 325 CommandArtifact artifact,
326 List<String> arguments, 326 List<String> arguments,
327 Map<String, String> environmentOverrides) { 327 Map<String, String> environmentOverrides) {
328 throw "Unimplemented runtime '$runtimeType'"; 328 throw "Unimplemented runtime '$runtimeType'";
329 } 329 }
330 } 330 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698