Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 21944004: Enable the accessibility audit for chrome://net-internals (Closed)

Created:
7 years, 4 months ago by dmazzoni
Modified:
7 years, 4 months ago
Reviewers:
aboxhall1, mmenke, aboxhall
CC:
chromium-reviews, tfarina, eroman, arv+watch_chromium.org
Visibility:
Public.

Description

Enable the accessibility audit for chrome://net-internals Fixes some tiny bugs - just unlabeled controls and colors that aren't sufficiently high-contrast. If any of these fixes are undesirable we can just suppress those errors instead. BUG=265583 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217775

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comments for suppressions #

Patch Set 3 : Rebase #

Patch Set 4 : Fix additional Chrome OS audit failure #

Patch Set 5 : Suppress one more false positive #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -29 lines) Patch
M chrome/browser/resources/net_internals/cros_log_analyzer_view.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/cros_log_analyzer_view.html View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/events_view.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/events_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/export_view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/net_internals/hsts_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/hsts_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/import_view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/net_internals/main.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/source_row.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/net_internals/status_view.css View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/net_internals/status_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/test_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/test_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/timeline_view.css View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/timeline_view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/net_internals/top_bar_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/net_internals/net_internals_test.js View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
dmazzoni
Alice, want to make sure this looks sane before I loop in net-internals owners?
7 years, 4 months ago (2013-08-02 19:32:36 UTC) #1
mmenke
On 2013/08/02 19:32:36, Dominic Mazzoni wrote: > Alice, want to make sure this looks sane ...
7 years, 4 months ago (2013-08-02 19:34:46 UTC) #2
mmenke
On 2013/08/02 19:34:46, mmenke wrote: > On 2013/08/02 19:32:36, Dominic Mazzoni wrote: > > Alice, ...
7 years, 4 months ago (2013-08-02 19:35:31 UTC) #3
dmazzoni
On 2013/08/02 19:35:31, mmenke wrote: > On 2013/08/02 19:34:46, mmenke wrote: > > On 2013/08/02 ...
7 years, 4 months ago (2013-08-02 19:51:08 UTC) #4
aboxhall1
With regard to accessibility going forward: I don't think there is any area of UI ...
7 years, 4 months ago (2013-08-02 19:57:01 UTC) #5
aboxhall
lgtm Nice one!
7 years, 4 months ago (2013-08-03 00:46:07 UTC) #6
dmazzoni
@mmenke: OK, please take a look when you have a chance. As I said above, ...
7 years, 4 months ago (2013-08-05 16:00:15 UTC) #7
mmenke
On 2013/08/02 19:57:01, aboxhall_google.com wrote: > With regard to accessibility going forward: I don't think ...
7 years, 4 months ago (2013-08-05 16:22:39 UTC) #8
mmenke
https://codereview.chromium.org/21944004/diff/1/chrome/browser/resources/net_internals/events_view.css File chrome/browser/resources/net_internals/events_view.css (right): https://codereview.chromium.org/21944004/diff/1/chrome/browser/resources/net_internals/events_view.css#newcode106 chrome/browser/resources/net_internals/events_view.css:106: color: rgb(235, 0, 0); Any reason we're using rgb(235,0,0) ...
7 years, 4 months ago (2013-08-05 16:23:13 UTC) #9
dmazzoni
On 2013/08/05 16:23:13, mmenke wrote: > https://codereview.chromium.org/21944004/diff/1/chrome/browser/resources/net_internals/events_view.css > File chrome/browser/resources/net_internals/events_view.css (right): > > https://codereview.chromium.org/21944004/diff/1/chrome/browser/resources/net_internals/events_view.css#newcode106 > ...
7 years, 4 months ago (2013-08-05 16:25:33 UTC) #10
mmenke
On 2013/08/05 16:25:33, Dominic Mazzoni wrote: > On 2013/08/05 16:23:13, mmenke wrote: > > > ...
7 years, 4 months ago (2013-08-05 16:29:05 UTC) #11
mmenke
On 2013/08/05 16:29:05, mmenke wrote: > On 2013/08/05 16:25:33, Dominic Mazzoni wrote: > > On ...
7 years, 4 months ago (2013-08-05 16:32:37 UTC) #12
dmazzoni
On Mon, Aug 5, 2013 at 9:29 AM, <mmenke@chromium.org> wrote: > > Any reason we're ...
7 years, 4 months ago (2013-08-05 16:36:33 UTC) #13
dmazzoni
On 2013/08/05 16:29:05, mmenke wrote: > > > Any reason we're using rgb(235,0,0) here and ...
7 years, 4 months ago (2013-08-05 16:39:24 UTC) #14
mmenke1
On 2013/08/05 16:39:24, Dominic Mazzoni wrote: > On 2013/08/05 16:29:05, mmenke wrote: > > > ...
7 years, 4 months ago (2013-08-05 16:42:59 UTC) #15
mmenke
On 2013/08/05 16:42:59, mmenke (incorrect) wrote: > On 2013/08/05 16:39:24, Dominic Mazzoni wrote: > > ...
7 years, 4 months ago (2013-08-05 16:45:22 UTC) #16
aboxhall1
That's a reasonable concern. I would answer that: - It really shouldn't take up too ...
7 years, 4 months ago (2013-08-05 16:45:51 UTC) #17
dmazzoni
On 2013/08/05 16:42:59, mmenke (incorrect) wrote: > But they're different colors: #E00 is rgb(238, 0, ...
7 years, 4 months ago (2013-08-05 16:47:07 UTC) #18
mmenke
On 2013/08/05 16:45:51, aboxhall_google.com wrote: > That's a reasonable concern. I would answer that: > ...
7 years, 4 months ago (2013-08-05 16:51:29 UTC) #19
dmazzoni
On Mon, Aug 5, 2013 at 9:51 AM, <mmenke@chromium.org> wrote: > It's more the color ...
7 years, 4 months ago (2013-08-05 17:21:29 UTC) #20
dmazzoni
On Mon, Aug 5, 2013 at 9:47 AM, <dmazzoni@chromium.org> wrote: > On 2013/08/05 16:42:59, mmenke ...
7 years, 4 months ago (2013-08-05 17:24:02 UTC) #21
mmenke
On 2013/08/05 17:21:29, Dominic Mazzoni wrote: > On Mon, Aug 5, 2013 at 9:51 AM, ...
7 years, 4 months ago (2013-08-05 17:34:45 UTC) #22
mmenke
On 2013/08/05 17:24:02, Dominic Mazzoni wrote: > On Mon, Aug 5, 2013 at 9:47 AM, ...
7 years, 4 months ago (2013-08-05 17:35:47 UTC) #23
aboxhall1
Thanks for the feedback - we're working on adding more information and suggestions to the ...
7 years, 4 months ago (2013-08-05 18:01:53 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/21944004/71002
7 years, 4 months ago (2013-08-15 05:51:36 UTC) #25
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 11:15:15 UTC) #26
Message was sent while issue was closed.
Change committed as 217775

Powered by Google App Engine
This is Rietveld 408576698