fpdfsdk/fpdfeditimg.cpp - Issue 2194393002: Fix a leak with FPDFPageObj_NewImgeObj().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfeditimg.cpp

Issue 2194393002: Fix a leak with FPDFPageObj_NewImgeObj(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfeditimg.cpp

diff --git a/fpdfsdk/fpdfeditimg.cpp b/fpdfsdk/fpdfeditimg.cpp

index cd283019770dde11f2c71674824435e513a219d8..da3d33eb05f47773878afd2d5197440969ee1ac8 100644

--- a/fpdfsdk/fpdfeditimg.cpp

+++ b/fpdfsdk/fpdfeditimg.cpp

@@ -19,7 +19,7 @@ FPDFPageObj_NewImgeObj(FPDF_DOCUMENT document) {

return nullptr;

CPDF_ImageObject* pImageObj = new CPDF_ImageObject;

- pImageObj->m_pImage = new CPDF_Image(pDoc);

+ pImageObj->SetOwnedImage(WrapUnique(new CPDF_Image(pDoc)));

return pImageObj;

}

« no previous file with comments | « core/fpdfapi/fpdf_page/include/cpdf_imageobject.h ('k') | fpdfsdk/fpdfeditimg_unittest.cpp » ('j') | no next file with comments »