core/fpdfapi/fpdf_page/pageint.h - Issue 2194393002: Fix a leak with FPDFPageObj_NewImgeObj().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/pageint.h

Issue 2194393002: Fix a leak with FPDFPageObj_NewImgeObj(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/pageint.h

diff --git a/core/fpdfapi/fpdf_page/pageint.h b/core/fpdfapi/fpdf_page/pageint.h

index 30c58745c61eeb4bcd53ebb37ecdfe12f133c791..d5c7cb396dc847c2c9f0ea2084abd4f9b79eba04 100644

--- a/core/fpdfapi/fpdf_page/pageint.h

+++ b/core/fpdfapi/fpdf_page/pageint.h

@@ -334,7 +334,7 @@ class CPDF_DocPageData {

const CFX_Matrix& matrix);

void ReleasePattern(const CPDF_Object* pPatternObj);

CPDF_Image* GetImage(CPDF_Object* pImageStream);

- void ReleaseImage(const CPDF_Object* pImageStream);

+ bool ReleaseImage(const CPDF_Object* pImageStream);

CPDF_IccProfile* GetIccProfile(CPDF_Stream* pIccProfileStream);

void ReleaseIccProfile(const CPDF_IccProfile* pIccProfile);

CPDF_StreamAcc* GetFontFileStreamAcc(CPDF_Stream* pFontStream);