syzygy/agent/common/hot_patcher.cc - Issue 2194383007: Port some more code to x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: syzygy/agent/common/hot_patcher.cc

Issue 2194383007: Port some more code to x64 (Closed) Base URL: git@github.com:google/syzygy.git@master

Patch Set: Rename the stack_walker unittest and fix the x86-64 implementation of stack_walker Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: syzygy/agent/common/hot_patcher.cc

diff --git a/syzygy/agent/common/hot_patcher.cc b/syzygy/agent/common/hot_patcher.cc

index 39cb5936fe43b2cbd908fdb982e9861460f31bc6..5b97835eba3ea31e89c4f45896dd431fa0cbe233 100644

--- a/syzygy/agent/common/hot_patcher.cc

+++ b/syzygy/agent/common/hot_patcher.cc

@@ -78,7 +78,7 @@ bool HotPatcher::Patch(FunctionPointer function_entry_point,

// Writes on x86 architecture are atomic within a cross 4-byte boundary.

// NOTE: This can be loosened. Any two bytes starting at an address that meets

// the (address % 4 != 3) condition does not cross 4-byte boundary.

- CHECK_EQ(0, reinterpret_cast<int>(jump_hook_place) % 2);

+ CHECK_EQ(0u, reinterpret_cast<uintptr_t>(jump_hook_place) % 2);

// We write the instruction JMP -5 which is represented as: 0xEB 0xF9

// We reverse the order of the bytes because of the little endian encoding

« no previous file with comments | « syzygy/agent/common/common.gyp ('k') | syzygy/agent/common/stack_capture.h » ('j') | no next file with comments »