Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: syzygy/agent/common/agent.cc

Issue 2194383007: Port some more code to x64 (Closed) Base URL: git@github.com:google/syzygy.git@master
Patch Set: Rename the stack_walker unittest and fix the x86-64 implementation of stack_walker Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | syzygy/agent/common/common.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/agent/common/agent.cc
diff --git a/syzygy/agent/common/agent.cc b/syzygy/agent/common/agent.cc
index 5721a8e2c2a5654f998f7c071d0535143f2be10b..f835af10b26aecc8bd6b425cad9837c8a6ac5737 100644
--- a/syzygy/agent/common/agent.cc
+++ b/syzygy/agent/common/agent.cc
@@ -29,8 +29,15 @@ void InitializeCrt() {
// Disable SSE2 instructions. This is to ensure that our instrumentation
// doesn't inadvertently tinker with SSE2 registers via the CRT, causing
// instrumented SSE2 enabled instructions to screw up.
+#ifndef _WIN64
+ // SSE registers are a part of the x64 calling convention, so they
+ // cannot be disabled.
+ // The 64-bit version of the runtime is intended to run with LLVM/Clang
+ // provided instrumentation, and doesn't suffer to same problem as the
+ // Syzygy instrumentation.
const int kDisableSSE2 = 0;
_set_SSE2_enable(kDisableSSE2);
+#endif
}
} // namespace common
« no previous file with comments | « no previous file | syzygy/agent/common/common.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698