Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2264)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 2194383004: [turbofan] Remove eager frame state from bitwise ops. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.h ('k') | src/compiler/operator-properties.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index e4e71fbf51f655e34f75da4fa6492c9e811325d4..23475c4b739c0165ec9f1763082987ea4e7ff007 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -582,7 +582,6 @@ Reduction JSTypedLowering::ReduceJSModulus(Node* node) {
Reduction JSTypedLowering::ReduceInt32Binop(Node* node,
const Operator* int_op) {
- if (flags() & kDisableIntegerBinaryOpReduction) return NoChange();
JSBinopReduction r(this, node);
BinaryOperationHints::Hint feedback = r.GetNumberBinaryOperationFeedback();
if (feedback != BinaryOperationHints::kAny) {
@@ -597,9 +596,15 @@ Reduction JSTypedLowering::ReduceInt32Binop(Node* node,
}
return r.ChangeToSpeculativeOperator(speculative_op, Type::Signed32());
}
- r.ConvertInputsToNumber();
- r.ConvertInputsToUI32(kSigned, kSigned);
- return r.ChangeToPureOperator(int_op, Type::Signed32());
+
+ // If deoptimization is enabled we rely on type feedback.
+ if (r.BothInputsAre(Type::PlainPrimitive()) ||
+ !(flags() & kDeoptimizationEnabled)) {
+ r.ConvertInputsToNumber();
+ r.ConvertInputsToUI32(kSigned, kSigned);
+ return r.ChangeToPureOperator(int_op, Type::Signed32());
+ }
+ return NoChange();
}
Reduction JSTypedLowering::ReduceUI32Shift(Node* node,
« no previous file with comments | « src/compiler/js-typed-lowering.h ('k') | src/compiler/operator-properties.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698