Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2194383004: [turbofan] Remove eager frame state from bitwise ops. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from bitwise ops. This removes the frame state input representing the before-state from nodes having any int32 bitwise operator. Lowering that inserts number conversions of the inputs has to be disabled when deoptimization is enabled, because the frame state layout is no longer known. R=epertoso@chromium.org BUG=v8:5021, v8:4746 Committed: https://crrev.com/0c8e3cea4b633d949caf5891c6092471ba7b9108 Cr-Commit-Position: refs/heads/master@{#38280}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/operator-properties.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-02 16:14:00 UTC) #3
epertoso
lgtm
4 years, 4 months ago (2016-08-03 08:13:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194383004/20001
4 years, 4 months ago (2016-08-03 08:33:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 08:35:03 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 08:39:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c8e3cea4b633d949caf5891c6092471ba7b9108
Cr-Commit-Position: refs/heads/master@{#38280}

Powered by Google App Engine
This is Rietveld 408576698