Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: ash/common/scoped_root_window_for_new_windows.h

Issue 2194353002: mash: Migrate ScopedTargetRootWindow to //ash/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reflow comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_SCOPED_TARGET_ROOT_WINDOW_H_ 5 #ifndef ASH_COMMON_SCOPED_ROOT_WINDOW_FOR_NEW_WINDOWS_H_
6 #define ASH_SCOPED_TARGET_ROOT_WINDOW_H_ 6 #define ASH_COMMON_SCOPED_ROOT_WINDOW_FOR_NEW_WINDOWS_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 10
11 namespace aura {
12 class Window;
13 }
14
15 namespace ash { 11 namespace ash {
16 12
17 // Constructing a ScopedTargetRootWindow allows temporarily 13 class WmWindow;
14
15 // Constructing a ScopedRootWindowForNewWindows allows temporarily
18 // switching a target root window so that a new window gets created 16 // switching a target root window so that a new window gets created
19 // in the same window where a user interaction happened. 17 // in the same window where a user interaction happened.
20 // An example usage is to specify the target root window when creating 18 // An example usage is to specify the target root window when creating
21 // a new window using launcher's icon. 19 // a new window using launcher's icon.
22 class ASH_EXPORT ScopedTargetRootWindow { 20 class ASH_EXPORT ScopedRootWindowForNewWindows {
23 public: 21 public:
24 explicit ScopedTargetRootWindow(aura::Window* root_window); 22 explicit ScopedRootWindowForNewWindows(WmWindow* new_root);
25 ~ScopedTargetRootWindow(); 23 ~ScopedRootWindowForNewWindows();
26 24
27 private: 25 private:
28 DISALLOW_COPY_AND_ASSIGN(ScopedTargetRootWindow); 26 WmWindow* old_root_;
James Cook 2016/08/02 00:27:50 I did this initially with base::AutoReset<> but th
msw 2016/08/02 01:04:50 Acknowledged.
27
28 DISALLOW_COPY_AND_ASSIGN(ScopedRootWindowForNewWindows);
29 }; 29 };
30 30
31 } // namespace ash 31 } // namespace ash
32 32
33 #endif // ASH_SCOPED_TARGET_ROOT_WINDOW_H_ 33 #endif // ASH_COMMON_SCOPED_ROOT_WINDOW_FOR_NEW_WINDOWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698