ash/common/scoped_root_window_for_new_windows.cc - Issue 2194353002: mash: Migrate ScopedTargetRootWindow to //ash/common

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/scoped_root_window_for_new_windows.cc

Issue 2194353002: mash: Migrate ScopedTargetRootWindow to //ash/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reflow comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/common/scoped_root_window_for_new_windows.h ('K') | « ash/common/scoped_root_window_for_new_windows.h ('k') | ash/common/system/toast/toast_overlay.cc » ('j') | ash/drag_drop/drag_drop_tracker_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ash/common/scoped_root_window_for_new_windows.h"

	6

	7 #include "ash/common/wm_shell.h"

	8 #include "base/logging.h"

	9

	10 namespace ash {

	11

	12 ScopedRootWindowForNewWindows::ScopedRootWindowForNewWindows(WmWindow* new_root)

	13 : old_root_(WmShell::Get()->root_window_for_new_windows()) {

	14 DCHECK(new_root);

	15 WmShell::Get()->set_root_window_for_new_windows(new_root);

	16 }

	17

	18 ScopedRootWindowForNewWindows::~ScopedRootWindowForNewWindows() {

	19 WmShell::Get()->set_root_window_for_new_windows(old_root_);
	msw 2016/08/02 01:04:50 I'm a little worried that this will break the valu I'm a little worried that this will break the value when multiple instances have overlapping lifetimes, or when something calls set_root_window_for_new_windows() directly during a ScopedRootWindowForNewWindows lifetime. Should WmShell use the existing approach in ash::Shell? (keeping a separate member for scoped values, setting that to null on scoped instance destruction, etc.) Otherwise, should this [D]CHECK that the current value matches \|new_root\|? James Cook 2016/08/02 16:16:04 Good call. This was the source of my interactive_u Show quoted text On 2016/08/02 01:04:50, msw wrote: > I'm a little worried that this will break the value when multiple instances have > overlapping lifetimes, or when something calls set_root_window_for_new_windows() > directly during a ScopedRootWindowForNewWindows lifetime. Should WmShell use the > existing approach in ash::Shell? (keeping a separate member for scoped values, > setting that to null on scoped instance destruction, etc.) Otherwise, should > this [D]CHECK that the current value matches \|new_root\|? Good call. This was the source of my interactive_ui_tests failure on the bots. Switched to the method used by ash::Shell.
	20 }

	21

	22 } // namespace ash

OLD	NEW