Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: runtime/vm/isolate_reload_test.cc

Issue 2194333002: RELOAD: Maintain identity of static tear-offs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/isolate_reload.cc ('K') | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_reload_test.cc
diff --git a/runtime/vm/isolate_reload_test.cc b/runtime/vm/isolate_reload_test.cc
index 46774c74798ed6eb77c7ef776af161ee7a6058ff..a3aece3d53a5d4b51652e8b02ec3ad7a6831b62e 100644
--- a/runtime/vm/isolate_reload_test.cc
+++ b/runtime/vm/isolate_reload_test.cc
@@ -1289,7 +1289,7 @@ TEST_CASE(IsolateReload_PendingSuperCall) {
}
-TEST_CASE(IsolateReload_TearOff_Equality) {
+TEST_CASE(IsolateReload_TearOff_Instance_Equality) {
const char* kScript =
"import 'test:isolate_reload_helper';\n"
"class C {\n"
@@ -1328,6 +1328,80 @@ TEST_CASE(IsolateReload_TearOff_Equality) {
}
+TEST_CASE(IsolateReload_TearOff_Class_Identity) {
+ const char* kScript =
+ "import 'test:isolate_reload_helper';\n"
+ "class C {\n"
+ " static foo() => 'old';\n"
+ "}\n"
+ "getFoo() => C.foo;\n"
+ "main() {\n"
+ " var f1 = getFoo();\n"
+ " reloadTest();\n"
+ " var f2 = getFoo();\n"
+ " return '${f1()} ${f2()} ${f1 == f2} ${identical(f1, f2)}';\n"
+ "}\n";
+
+ Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
+ EXPECT_VALID(lib);
+
+ const char* kReloadScript =
+ "import 'test:isolate_reload_helper';\n"
+ "class C {\n"
+ " static foo() => 'new';\n"
+ "}\n"
+ "getFoo() => C.foo;\n"
+ "main() {\n"
+ " var f1 = getFoo();\n"
+ " reloadTest();\n"
+ " var f2 = getFoo();\n"
+ " return '${f1()} ${f2()} ${f1 == f2} ${identical(f1, f2)}';\n"
+ "}\n";
+
+ TestCase::SetReloadTestScript(kReloadScript);
+
+ EXPECT_STREQ("new new true true", SimpleInvokeStr(lib, "main"));
+
+ lib = TestCase::GetReloadErrorOrRootLibrary();
+ EXPECT_VALID(lib);
+}
+
+
+TEST_CASE(IsolateReload_TearOff_Library_Identity) {
+ const char* kScript =
+ "import 'test:isolate_reload_helper';\n"
+ "foo() => 'old';\n"
+ "getFoo() => foo;\n"
+ "main() {\n"
+ " var f1 = getFoo();\n"
+ " reloadTest();\n"
+ " var f2 = getFoo();\n"
+ " return '${f1()} ${f2()} ${f1 == f2} ${identical(f1, f2)}';\n"
+ "}\n";
+
+ Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
+ EXPECT_VALID(lib);
+
+ const char* kReloadScript =
+ "import 'test:isolate_reload_helper';\n"
+ "foo() => 'new';\n"
+ "getFoo() => foo;\n"
+ "main() {\n"
+ " var f1 = getFoo();\n"
+ " reloadTest();\n"
+ " var f2 = getFoo();\n"
+ " return '${f1()} ${f2()} ${f1 == f2} ${identical(f1, f2)}';\n"
+ "}\n";
+
+ TestCase::SetReloadTestScript(kReloadScript);
+
+ EXPECT_STREQ("new new true true", SimpleInvokeStr(lib, "main"));
+
+ lib = TestCase::GetReloadErrorOrRootLibrary();
+ EXPECT_VALID(lib);
+}
+
+
TEST_CASE(IsolateReload_TearOff_List_Set) {
const char* kScript =
"import 'test:isolate_reload_helper';\n"
« runtime/vm/isolate_reload.cc ('K') | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698