Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194333002: RELOAD: Maintain identity of static tear-offs. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -9 lines) Patch
M runtime/vm/isolate_reload.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/isolate_reload_test.cc View 2 chunks +75 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object_reload.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmacnak
4 years, 4 months ago (2016-08-01 20:48:24 UTC) #2
turnidge
lgtm w/ comment. https://codereview.chromium.org/2194333002/diff/1/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2194333002/diff/1/runtime/vm/isolate_reload.cc#newcode1004 runtime/vm/isolate_reload.cc:1004: } Perhaps this should be implemented ...
4 years, 4 months ago (2016-08-01 21:04:28 UTC) #4
Cutch
https://codereview.chromium.org/2194333002/diff/1/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2194333002/diff/1/runtime/vm/isolate_reload.cc#newcode989 runtime/vm/isolate_reload.cc:989: functions = old_cls.functions(); please factor this into a function ...
4 years, 4 months ago (2016-08-01 22:26:04 UTC) #5
rmacnak
https://codereview.chromium.org/2194333002/diff/1/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2194333002/diff/1/runtime/vm/isolate_reload.cc#newcode989 runtime/vm/isolate_reload.cc:989: functions = old_cls.functions(); On 2016/08/01 22:26:04, Cutch wrote: > ...
4 years, 4 months ago (2016-08-02 00:43:45 UTC) #6
rmacnak
4 years, 4 months ago (2016-08-02 00:44:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ccaf6c68348e888eb29270036b25b41584323e80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698