Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2194283002: [ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase. SpinRunLoopWithMaxDelay which was used previously may return before delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that delay has passed. BUG=None Committed: https://crrev.com/5e89215d90cc2cbaf643638ce08c570e54ffdaa5 Cr-Commit-Position: refs/heads/master@{#409210}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M base/test/ios/wait_util.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M base/test/ios/wait_util.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/web/shell/test/meta_tags_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-08-01 18:47:57 UTC) #2
baxley
LGTM for EarlGrey. The base code looks fine, but I don't know if there is ...
4 years, 4 months ago (2016-08-01 21:18:45 UTC) #3
rohitrao (ping after 24h)
https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h File base/test/ios/wait_util.h (right): https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h#newcode47 base/test/ios/wait_util.h:47: // within the given minimum delay. This method returns ...
4 years, 4 months ago (2016-08-02 15:52:37 UTC) #4
Eugene But (OOO till 7-30)
PTAL https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h File base/test/ios/wait_util.h (right): https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h#newcode47 base/test/ios/wait_util.h:47: // within the given minimum delay. This method ...
4 years, 4 months ago (2016-08-02 15:57:28 UTC) #5
rohitrao (ping after 24h)
lgtm
4 years, 4 months ago (2016-08-02 15:59:52 UTC) #7
Eugene But (OOO till 7-30)
Thanks everyone!
4 years, 4 months ago (2016-08-02 16:02:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194283002/20001
4 years, 4 months ago (2016-08-02 16:02:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 16:48:02 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 16:49:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e89215d90cc2cbaf643638ce08c570e54ffdaa5
Cr-Commit-Position: refs/heads/master@{#409210}

Powered by Google App Engine
This is Rietveld 408576698