[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

SpinRunLoopWithMaxDelay which was used previously may return before
delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that
delay has passed.

BUG=None

Committed: https://crrev.com/5e89215d90cc2cbaf643638ce08c570e54ffdaa5
Cr-Commit-Position: refs/heads/master@{#409210}

[Eugene But (OOO till 7-30), 2016-08-01 18:47:56]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org, rohitrao@chromium.org

[baxley, 2016-08-01 21:18:45]

LGTM for EarlGrey. The base code looks fine, but I don't know if there is some
Apple API that works better than doing a loop.

[rohitrao (ping after 24h), 2016-08-02 15:52:37]

https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h
File base/test/ios/wait_util.h (right):

https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h#n...
base/test/ios/wait_util.h:47: // within the given minimum delay. This method
returns after max_delay elapsed.
What is "max_delay" in this context?  Should that be min_delay?

[Eugene But (OOO till 7-30), 2016-08-02 15:57:28]

PTAL

https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h
File base/test/ios/wait_util.h (right):

https://codereview.chromium.org/2194283002/diff/1/base/test/ios/wait_util.h#n...
base/test/ios/wait_util.h:47: // within the given minimum delay. This method
returns after max_delay elapsed.
On 2016/08/02 15:52:37, rohitrao wrote:
> What is "max_delay" in this context?  Should that be min_delay?
Yes, this should be |min_delay|. Thanks for catching.

[rohitrao (ping after 24h), 2016-08-02 15:59:47]

Description was changed from

==========
[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

SpinRunLoopWithMaxDelay which was used previously amy return before
delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that
delay has passed.

BUG=None
==========

to

==========
[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

SpinRunLoopWithMaxDelay which was used previously may return before
delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that
delay has passed.

BUG=None
==========

[rohitrao (ping after 24h), 2016-08-02 15:59:52]

lgtm

[Eugene But (OOO till 7-30), 2016-08-02 16:02:21]

Thanks everyone!

[Eugene But (OOO till 7-30), 2016-08-02 16:02:26]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-08-02 16:02:26]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2194283002/#ps20001
(title: "Addressed review comment")

[commit-bot: I haz the power, 2016-08-02 16:02:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 16:48:01]

Description was changed from

==========
[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

SpinRunLoopWithMaxDelay which was used previously may return before
delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that
delay has passed.

BUG=None
==========

to

==========
[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

SpinRunLoopWithMaxDelay which was used previously may return before
delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that
delay has passed.

BUG=None
==========

[commit-bot: I haz the power, 2016-08-02 16:48:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 16:49:16]

Description was changed from

==========
[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

SpinRunLoopWithMaxDelay which was used previously may return before
delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that
delay has passed.

BUG=None
==========

to

==========
[ios] Use SpinRunLoopWithMinDelay in MetaTagsTestCase.

SpinRunLoopWithMaxDelay which was used previously may return before
delay has elapsed. SpinRunLoopWithMinDelay will always guarantee that
delay has passed.

BUG=None

Committed: https://crrev.com/5e89215d90cc2cbaf643638ce08c570e54ffdaa5
Cr-Commit-Position: refs/heads/master@{#409210}
==========

[commit-bot: I haz the power, 2016-08-02 16:49:19]

Patchset 2 (id:??) landed as
https://crrev.com/5e89215d90cc2cbaf643638ce08c570e54ffdaa5
Cr-Commit-Position: refs/heads/master@{#409210}