Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp

Issue 2194273002: Fix border radius on composited children. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch to using the layer's offsetFromLayoutObject Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
index 8ed7a2e8750bd33e608b4aff16bb47cd6573e0ee..9b8f55a12f905c8e02fb22c628032d3503d028ea 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
@@ -345,9 +345,10 @@ void PaintLayerClipper::calculateRects(
// Update the clip rects that will be passed to child layers.
if (shouldClipOverflow(context)) {
- foregroundRect.intersect(
+ LayoutRect offsetOverflowClipRect =
toLayoutBox(layoutObject)
- .overflowClipRect(offset, context.overlayScrollbarClipBehavior));
+ .overflowClipRect(offset, context.overlayScrollbarClipBehavior);
+ foregroundRect.intersect(offsetOverflowClipRect);
chrishtr 2016/12/02 19:21:47 Is this just increasing clarity?
Stephen Chennney 2016/12/07 21:39:38 It was for debugging output. I've reverted it.
if (layoutObject.styleRef().hasBorderRadius())
foregroundRect.setHasRadius(true);

Powered by Google App Engine
This is Rietveld 408576698