chrome/browser/ui/fast_unload_controller.cc - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fast_unload_controller.cc

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/fast_unload_controller.cc

diff --git a/chrome/browser/ui/fast_unload_controller.cc b/chrome/browser/ui/fast_unload_controller.cc

index f0577567cf6954b3b9301a5314ab721e5a3b683d..94b0ce3004f518e9a6bc0cfa62c24a9944a87249 100644

--- a/chrome/browser/ui/fast_unload_controller.cc

+++ b/chrome/browser/ui/fast_unload_controller.cc

@@ -36,7 +36,8 @@ class FastUnloadController::DetachedWebContentsDelegate

private:

// WebContentsDelegate implementation.

- bool ShouldSuppressDialogs(content::WebContents* source) override {

+ bool ShouldSuppressDialogs(content::WebContents* source,

+ bool before_unload) override {

return true; // Return true so dialogs are suppressed.

}

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »