chrome/browser/prerender/prerender_manager.cc - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prerender/prerender_manager.cc

diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc

index 9380c80747e20c497339a506a2c3525afdbf182e..7813b5e7ff477b48077df141492f65c058148116 100644

--- a/chrome/browser/prerender/prerender_manager.cc

+++ b/chrome/browser/prerender/prerender_manager.cc

@@ -108,7 +108,7 @@ class PrerenderManager::OnCloseWebContentsDeleter

ScheduleWebContentsForDeletion(false);

}

- bool ShouldSuppressDialogs(WebContents* source) override {

+ bool ShouldSuppressDialogs(WebContents* source, bool before_unload) override {

// Use this as a proxy for getting statistics on how often we fail to honor

// the beforeunload event.

DCHECK_EQ(tab_.get(), source);

« no previous file with comments | « chrome/browser/prerender/prerender_contents.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »