chrome/browser/background/background_contents.h - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents.h

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/background/background_contents.h

diff --git a/chrome/browser/background/background_contents.h b/chrome/browser/background/background_contents.h

index 08c740de59f6ca07c0f1ec042b6dc6ff5da7f5c8..b60ee4e8a6d9d0049707b4abf42880be7c5358af 100644

--- a/chrome/browser/background/background_contents.h

+++ b/chrome/browser/background/background_contents.h

@@ -73,7 +73,8 @@ class BackgroundContents : public extensions::DeferredStartRenderHost,

// content::WebContentsDelegate implementation:

void CloseContents(content::WebContents* source) override;

- bool ShouldSuppressDialogs(content::WebContents* source) override;

+ bool ShouldSuppressDialogs(content::WebContents* source,

+ bool before_unload) override;

void DidNavigateMainFramePostCommit(content::WebContents* tab) override;

void AddNewContents(content::WebContents* source,

content::WebContents* new_contents,

« no previous file with comments | « apps/custom_launcher_page_contents.cc ('k') | chrome/browser/background/background_contents.cc » ('j') | no next file with comments »