apps/custom_launcher_page_contents.h - Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/custom_launcher_page_contents.h

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch fullscreen call Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/custom_launcher_page_contents.h

diff --git a/apps/custom_launcher_page_contents.h b/apps/custom_launcher_page_contents.h

index d08a2855a79b5ea17596b5413127a854559c6bd7..d03018af33f3e4b622133479c6aad88ba24acd28 100644

--- a/apps/custom_launcher_page_contents.h

+++ b/apps/custom_launcher_page_contents.h

@@ -49,7 +49,8 @@ class CustomLauncherPageContents : public content::WebContentsDelegate {

bool user_gesture,

bool* was_blocked) override;

bool IsPopupOrPanel(const content::WebContents* source) const override;

- bool ShouldSuppressDialogs(content::WebContents* source) override;

+ bool ShouldSuppressDialogs(content::WebContents* source,

+ bool before_unload) override;

bool PreHandleGestureEvent(content::WebContents* source,

const blink::WebGestureEvent& event) override;

content::ColorChooser* OpenColorChooser(

« no previous file with comments | « no previous file | apps/custom_launcher_page_contents.cc » ('j') | no next file with comments »