Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: chrome/browser/prerender/prerender_contents.cc

Issue 2194243002: Suppress JavaScript dialogs when a tab puts itself into fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: switch fullscreen call Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_contents.h" 5 #include "chrome/browser/prerender/prerender_contents.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <functional> 10 #include <functional>
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 bool OnGoToEntryOffset(int offset) override { 141 bool OnGoToEntryOffset(int offset) override {
142 // This isn't allowed because the history merge operation 142 // This isn't allowed because the history merge operation
143 // does not work if there are renderer issued challenges. 143 // does not work if there are renderer issued challenges.
144 // TODO(cbentzel): Cancel in this case? May not need to do 144 // TODO(cbentzel): Cancel in this case? May not need to do
145 // since render-issued offset navigations are not guaranteed, 145 // since render-issued offset navigations are not guaranteed,
146 // but indicates that the page cares about the history. 146 // but indicates that the page cares about the history.
147 return false; 147 return false;
148 } 148 }
149 149
150 bool ShouldSuppressDialogs(WebContents* source) override { 150 bool ShouldSuppressDialogs(WebContents* source, bool before_unload) override {
151 // We still want to show the user the message when they navigate to this 151 // We still want to show the user the message when they navigate to this
152 // page, so cancel this prerender. 152 // page, so cancel this prerender.
153 prerender_contents_->Destroy(FINAL_STATUS_JAVASCRIPT_ALERT); 153 prerender_contents_->Destroy(FINAL_STATUS_JAVASCRIPT_ALERT);
154 // Always suppress JavaScript messages if they're triggered by a page being 154 // Always suppress JavaScript messages if they're triggered by a page being
155 // prerendered. 155 // prerendered.
156 return true; 156 return true;
157 } 157 }
158 158
159 void RegisterProtocolHandler(WebContents* web_contents, 159 void RegisterProtocolHandler(WebContents* web_contents,
160 const std::string& protocol, 160 const std::string& protocol,
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 void PrerenderContents::AddResourceThrottle( 719 void PrerenderContents::AddResourceThrottle(
720 const base::WeakPtr<PrerenderResourceThrottle>& throttle) { 720 const base::WeakPtr<PrerenderResourceThrottle>& throttle) {
721 resource_throttles_.push_back(throttle); 721 resource_throttles_.push_back(throttle);
722 } 722 }
723 723
724 void PrerenderContents::AddNetworkBytes(int64_t bytes) { 724 void PrerenderContents::AddNetworkBytes(int64_t bytes) {
725 network_bytes_ += bytes; 725 network_bytes_ += bytes;
726 } 726 }
727 727
728 } // namespace prerender 728 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tab_capture/offscreen_tab.cc ('k') | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698