Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2194223002: Remove Fuchsia build from the gyp build (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Fuchsia build from the gyp build This isn't used anymore. The build happens in the Fuchsia tree using GN. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a274332ed79478c9aca9a965d529db8ed9556534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -330 lines) Patch
M tools/build.py View 5 chunks +3 lines, -34 lines 0 comments Download
D tools/fuchsia_link.py View 1 chunk +0 lines, -127 lines 0 comments Download
M tools/gyp/configurations.gypi View 2 chunks +0 lines, -16 lines 0 comments Download
D tools/gyp/configurations_fuchsia.gypi View 1 chunk +0 lines, -152 lines 0 comments Download
M tools/utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 4 months ago (2016-08-01 16:02:48 UTC) #2
siva
lgtm
4 years, 4 months ago (2016-08-01 17:46:42 UTC) #3
zra
4 years, 4 months ago (2016-08-01 19:38:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a274332ed79478c9aca9a965d529db8ed9556534 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698