components/ntp_snippets/content_suggestions_service_unittest.cc - Issue 2194203002: Make ContentSuggestionsService recognize new/removed categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_service_unittest.cc

Issue 2194203002: Make ContentSuggestionsService recognize new/removed categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renaming

Patch Set: Put the status-change notification back in RegisterProvider() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/content_suggestions_service.cc ('K') | « components/ntp_snippets/content_suggestions_service.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/content_suggestions_service_unittest.cc

diff --git a/components/ntp_snippets/content_suggestions_service_unittest.cc b/components/ntp_snippets/content_suggestions_service_unittest.cc

index c56da1e0c1b53b5f800121364357783e759a90ef..4979ced74ef8a9cd7b3997cae2b136a7b8d9ec0d 100644

--- a/components/ntp_snippets/content_suggestions_service_unittest.cc

+++ b/components/ntp_snippets/content_suggestions_service_unittest.cc

@@ -76,12 +76,12 @@ class MockProvider : public ContentSuggestionsProvider {

}

void FireSuggestionsChanged(Category category, std::vector<int> numbers) {

- observer_->OnNewSuggestions(category, CreateSuggestions(numbers));

+ observer_->OnNewSuggestions(this, category, CreateSuggestions(numbers));

}

void FireCategoryStatusChanged(Category category, CategoryStatus new_status) {

statuses_[category.id()] = new_status;

- observer_->OnCategoryStatusChanged(category, new_status);

+ observer_->OnCategoryStatusChanged(this, category, new_status);

}

void FireShutdown() {