components/ntp_snippets/ntp_snippets_service.cc - Issue 2194203002: Make ContentSuggestionsService recognize new/removed categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2194203002: Make ContentSuggestionsService recognize new/removed categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renaming

Patch Set: Marc's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/content_suggestions_service_unittest.cc ('k') | components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index 2098e6ab758076c2f9a2016087d38429cc13924f..def66cb058631176787cd94ea42163b3495cbdee 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -815,7 +815,7 @@ void NTPSnippetsService::NotifyNewSuggestions() {

suggestion.set_score(snippet->score());

result.emplace_back(std::move(suggestion));

}

- observer_->OnNewSuggestions(provided_category_, std::move(result));

+ observer_->OnNewSuggestions(this, provided_category_, std::move(result));

}

void NTPSnippetsService::UpdateCategoryStatus(CategoryStatus status) {

@@ -824,7 +824,8 @@ void NTPSnippetsService::UpdateCategoryStatus(CategoryStatus status) {

category_status_ = status;

if (observer_) {

- observer_->OnCategoryStatusChanged(provided_category_, category_status_);

+ observer_->OnCategoryStatusChanged(this, provided_category_,

+ category_status_);

}