Make ContentSuggestionsService recognize new/removed categories

components/ntp_snippets/content_suggestions_service.h

Index: components/ntp_snippets/content_suggestions_service.h
diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h
index 24be9beacb519b6e7af1ceda6490aad8c2a964c5..d35d2e232b74da1adda7ac45e19fabd5ef8d50ff 100644
--- a/components/ntp_snippets/content_suggestions_service.h
+++ b/components/ntp_snippets/content_suggestions_service.h
@@ -126,14 +126,19 @@ class ContentSuggestionsService : public KeyedService,
   };
 
   // Implementation of ContentSuggestionsProvider::Observer.
-  void OnNewSuggestions(Category changed_category,
+  void OnNewSuggestions(ContentSuggestionsProvider* provider,
+                        Category category,
                         std::vector<ContentSuggestion> suggestions) override;
-  void OnCategoryStatusChanged(Category changed_category,
+  void OnCategoryStatusChanged(ContentSuggestionsProvider* provider,
+                               Category category,
                                CategoryStatus new_status) override;
   void OnProviderShutdown(ContentSuggestionsProvider* provider) override;
 
-  // Checks whether a provider for the given |category| is registered.
-  bool IsCategoryRegistered(Category category) const;
+  // Registers the given |provider| for the given |category|, unless it is
+  // already registered. Returns true if the category was newly registered or
+  // false if it was present before.
+  bool RegisterCategoryIfRequired(ContentSuggestionsProvider* provider,
+                                Category category);

[Marc Treib, 2016/08/01 17:30:35]

misaligned

[Philipp Keck, 2016/08/02 08:34:38]

Done.

 
   // Fires the OnCategoryStatusChanged event for the given |category|.
   void NotifyCategoryStatusChanged(Category category);
@@ -148,7 +153,7 @@ class ContentSuggestionsService : public KeyedService,
   // provides multiple categories. The keys of this map are exactly the entries
   // of |categories_|.
   std::map<Category, ContentSuggestionsProvider*, CompareCategoriesByID>
-      providers_;
+      providers_by_category_;
 
   // All current suggestion categories, in an order determined by the
   // |category_factory_|. This vector contains exactly the same categories as