Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4727)

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc

Issue 2194193002: Fix ArcBridgeBootstrap race issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ArcBridgeBootstrap race issues. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/policy/policy_browsertest.cc » ('j') | components/arc/arc_bridge_bootstrap.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
diff --git a/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc b/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
index 2130e9475852f4acbe0f68b5d61f2ac976464947..ccefe4df6df697a4fa1645b1ace9bfbdf0329f17 100644
--- a/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
+++ b/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
@@ -32,7 +32,6 @@
#include "components/arc/arc_bridge_service_impl.h"
#include "components/arc/arc_service_manager.h"
#include "components/arc/test/fake_arc_bridge_bootstrap.h"
-#include "components/arc/test/fake_arc_bridge_instance.h"
#include "components/policy/core/common/policy_switches.h"
#include "components/prefs/pref_member.h"
#include "components/prefs/pref_service.h"
@@ -111,7 +110,8 @@ class ArcAuthServiceShutdownObserver : public ArcAuthServiceObserver {
DISALLOW_COPY_AND_ASSIGN(ArcAuthServiceShutdownObserver);
};
-class ArcAuthServiceTest : public InProcessBrowserTest {
+class ArcAuthServiceTest : public InProcessBrowserTest,
+ public ArcBridgeServiceImpl::Delegate {
protected:
ArcAuthServiceTest() {}
@@ -140,10 +140,9 @@ class ArcAuthServiceTest : public InProcessBrowserTest {
fake_session_manager_client));
// Mock out ARC bridge.
- fake_arc_bridge_instance_.reset(new FakeArcBridgeInstance);
- ArcServiceManager::SetArcBridgeServiceForTesting(
- base::WrapUnique(new ArcBridgeServiceImpl(base::WrapUnique(
- new FakeArcBridgeBootstrap(fake_arc_bridge_instance_.get())))));
+ std::unique_ptr<ArcBridgeServiceImpl> service(new ArcBridgeServiceImpl);
+ service->SetDelegateForTesting(this);
+ ArcServiceManager::SetArcBridgeServiceForTesting(std::move(service));
}
void SetUpOnMainThread() override {
@@ -205,8 +204,12 @@ class ArcAuthServiceTest : public InProcessBrowserTest {
FakeProfileOAuth2TokenService* token_service() { return token_service_; }
private:
+ // ArcBridgeServiceImpl::Delegate override:
+ std::unique_ptr<ArcBridgeBootstrap> CreateBootstrap() override {
+ return base::WrapUnique(new FakeArcBridgeBootstrap);
+ }
+
std::unique_ptr<policy::LocalPolicyTestServer> test_server_;
- std::unique_ptr<FakeArcBridgeInstance> fake_arc_bridge_instance_;
std::unique_ptr<chromeos::ScopedUserManagerEnabler> user_manager_enabler_;
base::ScopedTempDir temp_dir_;
std::unique_ptr<TestingProfile> profile_;
« no previous file with comments | « no previous file | chrome/browser/policy/policy_browsertest.cc » ('j') | components/arc/arc_bridge_bootstrap.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698