Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc

Issue 2194193002: Fix ArcBridgeBootstrap race issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
diff --git a/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc b/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
index 4803a9d1d0666355adc920e8d856de02052d979c..ad3228ecd78a86a7930ad0fb780badc552bab5bb 100644
--- a/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
+++ b/chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc
@@ -32,7 +32,6 @@
#include "components/arc/arc_bridge_service_impl.h"
#include "components/arc/arc_service_manager.h"
#include "components/arc/test/fake_arc_bridge_bootstrap.h"
-#include "components/arc/test/fake_arc_bridge_instance.h"
#include "components/policy/core/common/policy_switches.h"
#include "components/prefs/pref_member.h"
#include "components/prefs/pref_service.h"
@@ -140,10 +139,10 @@ class ArcAuthServiceTest : public InProcessBrowserTest {
fake_session_manager_client));
// Mock out ARC bridge.
- fake_arc_bridge_instance_.reset(new FakeArcBridgeInstance);
- ArcServiceManager::SetArcBridgeServiceForTesting(
- base::MakeUnique<ArcBridgeServiceImpl>(base::WrapUnique(
- new FakeArcBridgeBootstrap(fake_arc_bridge_instance_.get()))));
+ auto service = base::MakeUnique<ArcBridgeServiceImpl>();
+ service->SetArcBridgeBootstrapFactoryForTesting(
+ base::Bind(FakeArcBridgeBootstrap::Create));
+ ArcServiceManager::SetArcBridgeServiceForTesting(std::move(service));
}
void SetUpOnMainThread() override {
@@ -206,7 +205,6 @@ class ArcAuthServiceTest : public InProcessBrowserTest {
private:
std::unique_ptr<policy::LocalPolicyTestServer> test_server_;
- std::unique_ptr<FakeArcBridgeInstance> fake_arc_bridge_instance_;
std::unique_ptr<chromeos::ScopedUserManagerEnabler> user_manager_enabler_;
base::ScopedTempDir temp_dir_;
std::unique_ptr<TestingProfile> profile_;
« no previous file with comments | « no previous file | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698